downgrade uglifyjs-webpack-plugin to v0.4#1201
Closed
thinhbuzz wants to merge 1 commit intovuejs-templates:developfrom
thinhbuzz:develop
Closed
downgrade uglifyjs-webpack-plugin to v0.4#1201thinhbuzz wants to merge 1 commit intovuejs-templates:developfrom thinhbuzz:develop
thinhbuzz wants to merge 1 commit intovuejs-templates:developfrom
thinhbuzz:develop
Conversation
because v1.0 using for webpack 4.0
thinhbuzz
changed the title
Contributor
|
That quote alone is no reason to not use this plugin. It is meant to work with webpack 3 just as well - it just won't be included into webpack before 4.0.0 But maybe we have to temporarily downgrade because of webpack-contrib/uglifyjs-webpack-plugin#197 I will take a closer look tomorrow afternoon, won't be on a laptop before that. |
Contributor
|
Note: downgrading the version won't be enough, as plugin options work differenlty for 0.4 and 1.0.0: |
Author
|
why do you want to ignore offcial note of plugin? |
Contributor
|
I didn't ignore it. I explained to you how I think you misunderstand it.
|
Contributor
|
Problem was fixed with v1.16 of the plugin, so we can close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because v1.0 using for webpack 4.0:
from uglifyjs-webpack-plugin: